Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for DOMStringList #4534

Merged
merged 3 commits into from
Jan 13, 2017
Merged

Add tests for DOMStringList #4534

merged 3 commits into from
Jan 13, 2017

Conversation

inexorabletash
Copy link
Member

For #4522 to unblock whatwg/html#2192

Not the most extensive test suite in the world and the dependency on IndexedDB is unfortunate, but it was handy.

Should the idlharness test remain stand-alone or be merged into html/dom/interfaces.html ?

@wpt-pr-bot
Copy link
Collaborator

idlArray.add_idls(idls);

idlArray.add_objects({
DOMStringList: [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use 'location.ancestorOrigins' here?

@zcorpan
Copy link
Member

zcorpan commented Jan 12, 2017

w3c-test:mirror

Copy link
Member

@zcorpan zcorpan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % 1 comment

@inexorabletash
Copy link
Member Author

Also added the missing [Exposed=(Window,Worker)] so the worker test actually does something. (Chrome is missing that [Exposed] per w3c/IndexedDB#118 so it fails all over the place, as expected)

@zcorpan zcorpan merged commit b94e060 into web-platform-tests:master Jan 13, 2017
@inexorabletash inexorabletash deleted the domstringlist branch February 17, 2017 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants